Add reconnection to local server if the connection is lost #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ff
reviewed
May 2, 2024
| @@ -52,6 +52,9 @@ const { argv } = yargs | |||
| .option('request-secure-tunnel', { | |||
| describe: 'Requests tunel server to create secure tunnel if it is available.', | |||
| }) | |||
| .option('local_max_reconnect_count', { | |||
| describe: 'Max number of reconnection retries to local server if it goes offline.', | |||
lib/TunnelCluster.js
Outdated
| remote.end(); | ||
|
|
||
| if(self.localReconnectionRetryCount < localReconnectionMaxRetryCount) | ||
| { |
9df906f6
requested review from
pokhodenko,
stan-lit,
ALjean,
yehor-manzhula and
stas-nc
yehor-manzhula
approved these changes
May 3, 2024
b1ff
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a local server tends to close connections for some reason (e.g. inactivity timeout), tunneling client shuts down a tunnel event if a local server is operational.
The fix allows the client to try to reconnect to local server a few times if the connection is lost.